[WIP] Bump CAPI to v1.10.0-rc.0 #5533
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5533 +/- ##
==========================================
- Coverage 52.86% 52.84% -0.02%
==========================================
Files 272 272
Lines 29474 29484 +10
==========================================
Hits 15582 15582
- Misses 13080 13090 +10
Partials 812 812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is hitting the same error as #5530. |
mboersma
force-pushed
the
capi-one-ten
branch
2 times, most recently
from
12f2a6f to
5e5d3a1
Compare
|
/assign @nawazkh |
The AzureCluster is getting it's name set to |
|
For example from one of the tests that is failing Workload cluster creation when Creating a highly available cluster with Azure CNI v1 [REQUIRED] [It] can create 3 control-plane nodes and 2 Linux worker nodes [Azure CNI v1]
/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/e2e/azure_test.go:298
Captured StdOut/StdErr Output >>
2025/04/07 19:42:31 failed trying to get namespace (capz-e2e-ovwnsn):namespaces "capz-e2e-ovwnsn" not found
<< Captured StdOut/StdErr Output
Timeline >>
INFO: "can create 3 control-plane nodes and 2 Linux worker nodes" started at Mon, 07 Apr 2025 19:42:31 UTC on Ginkgo node 6 of 10 and junit test report to file /logs/artifacts/test_e2e_junit.e2e_suite.1.xml
STEP: Creating namespace "capz-e2e-ovwnsn" for hosting the cluster @ 04/07/25 19:42:31.291
Apr 7 19:42:31.291: INFO: starting to create namespace for hosting the "capz-e2e-ovwnsn" test spec
INFO: Creating namespace capz-e2e-ovwnsn
INFO: Creating event watcher for namespace "capz-e2e-ovwnsn"
INFO: Cluster name is capz-e2e-ovwnsn-azcni-v1
INFO: Creating the workload cluster with name "capz-e2e-ovwnsn-azcni-v1" using the "azure-cni-v1" template (Kubernetes v1.29.12, 3 control-plane machines, 2 worker machines)
INFO: Getting the cluster template yaml
INFO: clusterctl config cluster capz-e2e-ovwnsn-azcni-v1 --infrastructure (default) --kubernetes-version v1.29.12 --control-plane-machine-count 3 --worker-machine-count 2 --flavor azure-cni-v1
INFO: Creating the workload cluster with name "capz-e2e-ovwnsn-azcni-v1" from the provided yaml
INFO: Applying the cluster template yaml of cluster capz-e2e-ovwnsn/capz-e2e-ovwnsn-azcni-v1
[FAILED] in [It] - /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/clusterctl/clusterctl_helpers.go:431 @ 04/07/25 19:43:31.816
Apr 7 19:43:31.816: INFO: FAILED!
Apr 7 19:43:31.816: INFO: Cleaning up after "Workload cluster creation when Creating a highly available cluster with Azure CNI v1 [REQUIRED] can create 3 control-plane nodes and 2 Linux worker nodes" spec
Apr 7 19:43:31.816: INFO: Dumping all the Cluster API resources in the "capz-e2e-ovwnsn" namespace
STEP: Redacting sensitive information from logs @ 04/07/25 19:43:31.818
[FAILED] in [AfterEach] - /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/alltypes_helpers.go:132 @ 04/07/25 19:43:33.65We do generate the cluster name. ( |
mboersma
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I was able to replicate the |
api/v1beta1/azurecluster_webhook.go
Outdated
| WithDefaulter(&AzureCluster{}). | ||
| WithValidator(&AzureCluster{}). |
There was a problem hiding this comment.
Still probing, but could setting this as empty structs be the issue ?
There was a problem hiding this comment.
Worth a try--I copied the empty struct pattern from CAPI without thinking about it much, but let's try using the calling structs instead.
There was a problem hiding this comment.
I made some progress on the tests with the commit e3c1ffd
My changes were inspired from https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1459/files
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.2.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/tracing/azotel v0.4.0 | ||
| github.com/Azure/azure-service-operator/v2 v2.11.0 | ||
| github.com/Azure/azure-service-operator/v2 v2.12.1-0.20250331045328-e711390fd009 |
There was a problem hiding this comment.
Sorry I dont fully understand this.
Is this commit e711390fd009 referring to the v2/go.mod in ASO with sigs.k8s.io/controller-runtime updated to v0.20.4 ?
If so, could you please mention how we got this commit tag ?
There was a problem hiding this comment.
I think this is referring to a commit after v2.12. It was pulled in by go get -u and things compiled, so I've left it intact, but I assume we want to replace it with v2.13 when that is released.
|
/test pull-cluster-api-provider-azure-ci-entrypoint |
|
@mboersma: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/close See #5517 |
|
@mboersma: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates CAPI to v1.10.0-rc.0.
Which issue(s) this PR fixes:
Fixes #5491
Special notes for your reviewer:
See controller-runtime v0.20 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.20.0
See CAPI 1.9 - 1.10 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.9-to-v1.10.md
TODOs:
Release note: